Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few tables are Celsius-only not adjustable #607

Open
rusefi opened this issue Aug 26, 2018 · 1 comment
Open

A few tables are Celsius-only not adjustable #607

rusefi opened this issue Aug 26, 2018 · 1 comment

Comments

@rusefi
Copy link
Collaborator

rusefi commented Aug 26, 2018

On startup we select Fahrenheit or Celsius but some tables do not care

curve = iatFuelCorrCurve, "Intake air temperature fuel Multiplier"
columnLabel = "Coolant", "Multiplier"
xAxis = -40, 120, 10

curve = cltTimingCorrCurve, "Warmup timing correction"
  columnLabel = "Coolant", "Extra"
  xAxis       =  -40, 120, 10
  yAxis       =  0,  50, 10
  xBins       = cltTimingBins, coolant


curve = cltFuelCorrCurve, "Warmup fuel manual Multiplier"
  columnLabel = "Coolant", "Multiplier"
  xAxis       =  -40, 120, 10
  yAxis       =  0,  50, 10
  xBins       = cltFuelCorrBins, coolant

curve = crankingCltCurve, "Cranking Coolant Temperature multiplier"
  columnLabel = "Coolant", "Multiplier"
  xAxis       =  -40, 120, 10
  yAxis       =  0,  5, 10
  xBins       = crankingFuelBins, coolant

and probably more

See examples like
#if CELSIUS
filter = minCltFilter, "Minimum CLT", coolant, < , 60, , true
#else
filter = minCltFilter, "Minimum CLT", coolant, < , 160, , true
#endif
and
#if CELSIUS
coolant = scalar, F32, 4, "°C", 1, 0.0
#else
coolant = scalar, F32, 4, "°F", {9/5}, 17.77777
#endif

for how things should be corrected

rusefi pushed a commit that referenced this issue Aug 26, 2018
@rusefi
Copy link
Collaborator Author

rusefi commented Aug 27, 2018

This would require a change to .ini generator - at the moment we have
float[IAT_CURVE_SIZE] iatFuelCorrBins;;"C", 1, 0, -100.0, 250.0, 2

would need to teach generator that these are not just float but temperature floats so that an in-statement is generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant