Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom board canned tune process would need board-specific x86 binary (simulator or unit_tests) #6195

Closed
rusefillc opened this issue Mar 10, 2024 · 4 comments · Fixed by #6216 or #6250
Assignees

Comments

@rusefillc
Copy link
Contributor

See https://github.com/rusefi/rusefi/wiki/Canned-Tune-Process#internal-implementation-details

Same as this main repo exports current engine-specific tune, custom boards should be exporting board-specific tunes.

rusefillc pushed a commit that referenced this issue Mar 10, 2024
rusefillc pushed a commit to rusefi/fw-custom-paralela that referenced this issue Mar 10, 2024
@rusefillc
Copy link
Contributor Author

For example fw-custom-paralela now has custom default tune rusefi/fw-custom-paralela@f7b99d2 which uses fbdad77 hook

I assume next step would be to compile simulator from within fw-custom-paralela with https://github.com/rusefi/fw-custom-paralela/blob/master/default_tune.cpp added into build

Executing such a simulator with ./build/rusefi_simulator 10 similar to https://github.com/rusefi/rusefi/blob/master/.github/workflows/build-simulator.yaml would produce default tune with https://github.com/rusefi/fw-custom-paralela/blob/master/default_tune.cpp accounted for, the rest I can deal with easily :)

@chuckwagoncomputing
Copy link
Member

Fixed with #6205 and rusefi/fw-custom-paralela#5
Example commit: rusefi/fw-custom-paralela@de776f8

@rusefillc
Copy link
Contributor Author

https://github.com/rusefi/fw-custom-paralela/blob/master/generated/simulator_tune.msq says <constant digits="3" name="displacement" units="L">2.0</constant> while https://github.com/rusefi/fw-custom-paralela/blob/master/default_tune.cpp is asking for 1.8

@rusefillc rusefillc reopened this Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
rusefillc pushed a commit that referenced this issue Mar 15, 2024
chuckwagoncomputing pushed a commit to chuckwagoncomputing/rusefi that referenced this issue Mar 15, 2024
chuckwagoncomputing pushed a commit to chuckwagoncomputing/rusefi that referenced this issue Mar 16, 2024
@rusefillc
Copy link
Contributor Author

@chuckwagoncomputing seems not to work at https://github.com/rusefi/fw-custom-example could be user (me) issue?

Expected tune change did not happen after tune change rusefi/fw-custom-example@c3b254d

https://github.com/rusefi/fw-custom-example/ is green and produces tunes rusefi/fw-custom-example@e82e6a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants