Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is scheduling_s::momentX field type? #6409

Closed
kifir23917 opened this issue Apr 24, 2024 · 6 comments
Closed

what is scheduling_s::momentX field type? #6409

kifir23917 opened this issue Apr 24, 2024 · 6 comments

Comments

@kifir23917
Copy link
Member

kifir23917 commented Apr 24, 2024

It looks like in live code we initialize scheduling_s::momentX field with microseconds, not with ticks: see here.
P.S. There exists code where we initialize this field with ticks, but it is under EFI_SIGNAL_EXECUTOR_ONE_TIMER compilation flag - is it still actual?

@rusefillc rusefillc changed the title Fix scheduling_s::momentX field type from efitick_t to efitimeus_t what is scheduling_s::momentX field type? Apr 24, 2024
@mck1117
Copy link
Contributor

mck1117 commented Apr 25, 2024

here

those are ticks, no?

@rusefillc
Copy link
Contributor

those are ticks, no?

it depends

schedulingQueue.insertTask(scheduling, timeUs, action);

@rusefillc
Copy link
Contributor

PS: I sense a template incoming?

@mck1117
Copy link
Contributor

mck1117 commented Apr 25, 2024

PS: I sense a template incoming?

overkill, tick and us are both int64_t

@rusefillc
Copy link
Contributor

overkill, tick and us are both int64_t

a template with a struct sprinkled to get strict typing?

@rusefillc
Copy link
Contributor

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants