-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what is scheduling_s::momentX field type? #6409
Labels
Comments
rusefillc
changed the title
Fix scheduling_s::momentX field type from efitick_t to efitimeus_t
what is scheduling_s::momentX field type?
Apr 24, 2024
rusefillc
added a commit
that referenced
this issue
Apr 24, 2024
rusefillc
added a commit
that referenced
this issue
Apr 24, 2024
those are ticks, no? |
it depends
|
PS: I sense a template incoming? |
overkill, tick and us are both int64_t |
a template with a struct sprinkled to get strict typing? |
kifir23917
added a commit
to kifir23917/libfirmware
that referenced
this issue
Apr 26, 2024
kifir23917
added a commit
to kifir23917/libfirmware
that referenced
this issue
Apr 26, 2024
kifir23917
added a commit
to kifir23917/libfirmware
that referenced
this issue
Apr 27, 2024
kifir23917
added a commit
to kifir23917/libfirmware
that referenced
this issue
Apr 27, 2024
kifir23917
added a commit
to kifir23917/rusefi
that referenced
this issue
Apr 28, 2024
kifir23917
added a commit
to kifir23917/libfirmware
that referenced
this issue
Apr 28, 2024
resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like in live code we initialize scheduling_s::momentX field with microseconds, not with ticks: see here.
P.S. There exists code where we initialize this field with ticks, but it is under
EFI_SIGNAL_EXECUTOR_ONE_TIMER
compilation flag - is it still actual?The text was updated successfully, but these errors were encountered: