Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

60/2 vs 60/2 VW mess #988

Closed
rusefi opened this issue Oct 30, 2019 · 19 comments
Closed

60/2 vs 60/2 VW mess #988

rusefi opened this issue Oct 30, 2019 · 19 comments
Labels

Comments

@rusefi
Copy link
Collaborator

rusefi commented Oct 30, 2019

We have two versions of 60/2 trigger - "60/2" and "60/2 VW"

looks like this is due to misunderstanding of how VR works, one is theoretical nice 60/2 Hall while the other one is real 60/2 VR signal

See also #707

@rusefi
Copy link
Collaborator Author

rusefi commented Oct 30, 2019

Matthew Kennedy 9:39 PM
a hall sensor engine will work fine with the VR config (ie, only decode one edge)
event every 6 degrees vs. event every 3 degrees isn't a difference, other than sucking up cpu cycles
new messages
whatever edge and type of sensor you have, if you see gap ratios of 1-1-1-2-2-1-1-1 instead of 1-1-1-3-1-1-1 then the polarity is wrong
russian 9:42 PM
hold on
do you mean
1-1-1-2-2-1-1-1 means polarity is wrong
and in case of wrong polarity, you will see 1-1-1-2-2-1-1-1?
Matthew Kennedy 9:42 PM
Yes

@rusefi
Copy link
Collaborator Author

rusefi commented Nov 16, 2019

INCORRECT VR wiring
2019-11-15_pin32_trigger_neg_2B_incorrect

CORRECT VR wiring
2019-11-15_pin32_trigger_pos_2A_correct

this is from my M73 confirming above opinion.

Top picture is wired INCORRECTLY while bottom picture is wired properly

@OrchardPerformance
Copy link
Contributor

Should these be referred to as 60-2 High gap and 60-2 Low gap.
Then it identifies the two traces by the physical feature of the wheels.
I think one signal comes from each kind of trigger wheel gap.

@OrchardPerformance
Copy link
Contributor

OrchardPerformance commented May 24, 2020

image
Low gap
60-2 VW pattern

@OrchardPerformance
Copy link
Contributor

OrchardPerformance commented May 24, 2020

image
high gap
Universal True 60-2 pattern

"trigger wheel wont work with a hall sensor since the "half depth" missing tooth will sometimes be seen as one long tooth."

@OrchardPerformance
Copy link
Contributor

OrchardPerformance commented May 24, 2020

https://www.hpacademy.com/forum/general-tuning-discussion/show/custom-60-2-wheel-suitable-tooth-dimensions

image

Although I would trash talk their comment about BMW and others being incorrect, that's a bosch wheel and bosch pattern, I would think they would get their own invention right.

@rusefillc
Copy link
Contributor

Status update: we are still a bit confused :)

But at least we now have nicer wheel shapes documentation at

https://github.com/rusefi/rusefi/wiki/All-Supported-Triggers#vw-602
and
https://github.com/rusefi/rusefi/wiki/All-Supported-Triggers#602

@mck1117
Copy link
Contributor

mck1117 commented Apr 12, 2021

Neither of those patterns matches the Renault pattern. The renault pattern missing tooth looks similar, but the first tooth after the gap is longer.

@rusefillc
Copy link
Contributor

@mck1117 FYI

@mck1117
Copy link
Contributor

mck1117 commented Jun 27, 2021

Nik's trigger looks like this:
image

@mck1117
Copy link
Contributor

mck1117 commented Jun 27, 2021

My missing tooth (missing gap) looks like this:
77323465-5479-45CF-9AC8-893042BB61EE

@mck1117
Copy link
Contributor

mck1117 commented Jun 27, 2021

As far as I can tell, these are the same, but one is inverted from the other.
But because of how the max992x works, you can't just invert in software, they actually require opposite sensor polarity.

@mi-hol
Copy link
Contributor

mi-hol commented Apr 2, 2023

My take from above comments is:

  • there is no real technical issue but just unclear documentation

Is this correct understanding?

@rusefillc
Copy link
Contributor

Not sure. Documentation implies user would manually locate documentation and understand it, I would prefer that we do smarter things like auto-detect the issue etc.

@mi-hol
Copy link
Contributor

mi-hol commented Apr 2, 2023

I would prefer that we do smarter things like auto-detect the issue etc.

While I understand and support this view, realistically auto-detect trigger pattern seems a too big task considering the currently available resources to fix this within a reasonable amount of time. Auto-detection had apparently no activities since 2017!
A viable short term fix to move forward with rusefi/rusefi_documentation#459 seems the approach with enhancing documentation only.
I'd be happy to be proven wrong though

@rusefillc
Copy link
Contributor

@rusefillc
Copy link
Contributor

rusefillc commented Apr 21, 2024

same M73 engines now flipped wires - should be proper polarity now

image

rusefillc pushed a commit that referenced this issue Apr 21, 2024
only: rename & flipping M73 canned tunes
@rusefillc
Copy link
Contributor

rusefillc pushed a commit to rusefi/rusefi_documentation that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants