[TCU] Button Shifting #1750
[TCU] Button Shifting #1750
Conversation
| setDesiredGear(NEUTRAL); | ||
| break; | ||
| case NEUTRAL: | ||
| setDesiredGear(GEAR_1); |
There was a problem hiding this comment.
we will soon have 8 gears, this would looks a bit nasty
we probably need gear_8 enum, a property for gears count, and less copy-paste next/previous implementation?
There was a problem hiding this comment.
yeah. also a real world car won't let the driver switch from neutral to 1st gear with the paddle shifters
There was a problem hiding this comment.
well this is more like "return DESIRED gear" vs "current gear"
"desired" we can blip from 2 to 5
There was a problem hiding this comment.
In other words, in the real world reverse, neutral, and 1st gear at least will be special cases. I could have implemented a simple increment/decrement with a gear count property, but I figured an example that could be easily modified to use in a real-world scenario would be better than one that had to be completely rewritten.
No description provided.