don't rely on triggerStateListener to detect trigger errors #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
once/if we are happy with this change can we merge test-only or mostly-test part first and then merge production code as separate merge? |
Merged
yeah, I already had to break part off in to #4165 |
Merged
|
This PR has a functional change at the moment? Split one green PR into two green PRs? |
mck1117
changed the title
mck1117
commented
May 13, 2022
| @@ -141,8 +140,8 @@ TEST(trigger, testNB2CamInput) { | |||
|
|
|||
| int totalRevolutionCountBeforeVvtSync = 5; | |||
| // need to be out of VVT sync to see VVT sync in action | |||
| eth.fireRise(25); | |||
| eth.fireRise(25); | |||
| eth.fireRise(25 * 70 / 180); | |||
There was a problem hiding this comment.
Hah! Mistake in the test caught by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that various sync problems cause
getShaftSynchronized()to return false.