ETB compensates for battery voltage #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's wait for release for this one |
mck1117
force-pushed
the
etb-voltage-compensation
branch
from
51ebced
to
34ce0c8
Compare
|
@mck1117 ready to merge? |
|
tested, works nicely |
|
plz CHANGELOG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that your ETB will behave the same at any battery voltage, including during cranking/failed alternator/etc. Importantly this means that when you autotune PID gains with the engine off, the extra 2-3 volts don't make your throttle overtuned when you start the engine.
Sort of related to #4816 since a weak battery could cause autocal fail in theory too.