-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Als timer #5040
Conversation
@TurboMarian an example of small pr which probably works on real firmware but seem to break unit tests. We care about unit tests. |
@TurboMarian how can I help revive all that? Would a video conf call? Should I fix this PR? anything else? |
To run the unit tests I follow the GitHub Workflow (https://github.com/rusefi/rusefi/blob/master/.github/workflows/build-unit-tests.yaml#L13), which is like:
|
@TurboMarian I've just picked some code from your fork. please rebase and go over missing parts |
@TurboMarian let's see if this one would be green
seems like those three are all about timer, not sure if that's the complete change