Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Als timer #5040

Closed
wants to merge 2 commits into from
Closed

Als timer #5040

wants to merge 2 commits into from

Conversation

rusefillc
Copy link
Contributor

@TurboMarian let's see if this one would be green

seems like those three are all about timer, not sure if that's the complete change

@rusefillc
Copy link
Contributor Author

@TurboMarian an example of small pr which probably works on real firmware but seem to break unit tests. We care about unit tests.

(cherry picked from commit 1c88ef4)
(cherry picked from commit 580ed2b)
@rusefillc
Copy link
Contributor Author

@TurboMarian how can I help revive all that? Would a video conf call? Should I fix this PR? anything else?

@TurboMarian
Copy link
Contributor

Could you give me a hint on how to do units tests on my computer?

Also that bit need to be changed Screenshot_20230222_204931_GitHub~2.jpg

to if (!ALSMaxRPMCondition) {ALStimer.reset();}

@nmschulte
Copy link
Contributor

To run the unit tests I follow the GitHub Workflow (https://github.com/rusefi/rusefi/blob/master/.github/workflows/build-unit-tests.yaml#L13), which is like:

pushd firmware/; ./gen_default_everything.sh; popd
pushd unit_tests/; make -j4 COVERAGE=yes; popd
pushd unit_tests/; ASAN_OPTIONS=detect_stack_use_after_return=1 build/rusefi_test; popd

rusefillc added a commit that referenced this pull request Feb 25, 2023
rusefillc added a commit that referenced this pull request Feb 25, 2023
rusefillc added a commit that referenced this pull request Feb 25, 2023
@rusefillc
Copy link
Contributor Author

@TurboMarian I've just picked some code from your fork. please rebase and go over missing parts

@rusefillc rusefillc closed this Feb 25, 2023
rusefillc added a commit that referenced this pull request Feb 25, 2023
rusefillc added a commit that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants