Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 50/83.3/125kbit CAN #5072

Merged
merged 3 commits into from Feb 13, 2023
Merged

add 50/83.3/125kbit CAN #5072

merged 3 commits into from Feb 13, 2023

Conversation

mck1117
Copy link
Member

@mck1117 mck1117 commented Feb 13, 2023 •
edited

  • Add 50kbit/s, 83.33kbit/s, 125kbit/s
  • Fix 100kbit on F7
  • Fix 100kbit on H7
  • tweak 250/500/1000kbit on H7
  • reorder CAN bitrate options so they're sorted with the new ones

@mck1117 mck1117 marked this pull request as draft February 13, 2023 20:15
@mck1117 mck1117 changed the title add 50kbit CAN add 50/83.3/125kbit CAN Feb 13, 2023
@rusefillc rusefillc mentioned this pull request Feb 13, 2023
Closed
@mck1117 mck1117 marked this pull request as ready for review February 13, 2023 21:45
@Er0pification
Copy link

Er0pification commented Feb 13, 2023 •
edited

reorder CAN bitrate options so they're sorted with the new ones
Is this the right thing to do? Kinda messes with existing configs

rusefillc
rusefillc reviewed Feb 13, 2023
View reviewed changes
firmware/integration/rusefi_config.txt
@@ -93,7 +93,7 @@
! Any time an incompatible change is made to the configuration format stored in flash,
! update this string to the current date! It is required to also update TS_SIGNATURE above
! when this happens.
#define FLASH_DATA_VERSION 10019
#define FLASH_DATA_VERSION 10020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Er0pification that's why FLASH_DATA_VERSION change to force configuration migration via TS

@rusefillc rusefillc merged commit 28babe5 into rusefi:master Feb 13, 2023
rusefillc added a commit that referenced this pull request Feb 13, 2023
@rusefillc
add 50/83.3/125kbit CAN #5072
d6fd5d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusefillc rusefillc rusefillc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mck1117 @Er0pification @rusefillc