fix #5160 #5164
fix #5160 #5164
Conversation
|
this PR is red |
|
looks like a fluke, and one I've never seen before
|
| float lambda = Sensor::getOrZero(SensorType::Lambda1); | ||
| // phi = 1 / lambda | ||
| float phi = clampF(0, 1 / lambda, 1.99f); | ||
| float lambda = clampF(0, Sensor::getOrZero(SensorType::Lambda1), 1.99f); |
There was a problem hiding this comment.
Just curious, why 1.99f vs e.g. 1.9999f -- I realize "< 2 ratio" is the concern; is the extra "top end" not really worth?
There was a problem hiding this comment.
nobody is running an engine anywhere near 2.0 lambda anyway
There was a problem hiding this comment.
yeah I figured.
also wondering, does rusEFI ever report the voltage (bytes CD) for OBD2 PIDs?
There was a problem hiding this comment.
Nope. Not much reason to unless you're doing "real" diagnosis using OBD2. We support OBD2 pretty much exclusively for gauges/dashes/apps/etc, not real diagnosis.
There was a problem hiding this comment.
We support OBD2 pretty much exclusively for gauges/dashes/apps/etc, not real diagnosis.
This statement is an important fact but it seems not captured in doc yet.
Is it ok that I add it to https://wiki.rusefi.com/CAN/ ?
send lambda properly over OBD2
fix #5160