Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETB on hellen everybody gets pwm on timer 3 #5196

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions firmware/config/boards/hellen/harley81/board.mk
Expand Up @@ -10,8 +10,6 @@ DDEFS += -DEFI_MAIN_RELAY_CONTROL=TRUE
DDEFS += -DFIRMWARE_ID=\"hellen81hd\"
DDEFS += -DEFI_SOFTWARE_KNOCK=TRUE -DSTM32_ADC_USE_ADC3=TRUE

DDEFS += -DSTM32_PWM_USE_TIM3=TRUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @mck1117


include $(BOARDS_DIR)/hellen/hellen-common144.mk

# Enable serial pins on expansion header
Expand Down
5 changes: 0 additions & 5 deletions firmware/hw_layer/ports/stm32/mcuconf_common_f4_f7.h
Expand Up @@ -209,12 +209,7 @@
#define STM32_PWM_USE_ADVANCED FALSE
#define STM32_PWM_USE_TIM1 FALSE
#define STM32_PWM_USE_TIM2 FALSE

#ifndef STM32_PWM_USE_TIM3
// Hellen often uses TIM3 for ETB
#define STM32_PWM_USE_TIM3 TRUE
#endif

#define STM32_PWM_USE_TIM4 TRUE
#define STM32_PWM_USE_TIM5 TRUE
#define STM32_PWM_USE_TIM8 TRUE
Expand Down
2 changes: 1 addition & 1 deletion firmware/hw_layer/ports/stm32/stm32h7/cfg/mcuconf.h
Expand Up @@ -356,7 +356,7 @@
#define STM32_PWM_USE_ADVANCED FALSE
#define STM32_PWM_USE_TIM1 FALSE
#define STM32_PWM_USE_TIM2 FALSE
#define STM32_PWM_USE_TIM3 FALSE
#define STM32_PWM_USE_TIM3 TRUE
#define STM32_PWM_USE_TIM4 TRUE
#define STM32_PWM_USE_TIM5 TRUE
#define STM32_PWM_USE_TIM8 TRUE
Expand Down