Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed Loop Idle Ignition Timing small improvements #5635

Merged
merged 12 commits into from Oct 24, 2023

Conversation

pchmura4
Copy link
Contributor

For aggressively tuned CL Idle Timing in some cases it could have a harsh entry after Cranking Taper to Idle.
I would like to introduce a simple idea that can make this more subtle I think.
obraz

Also I think it would be nice to enable Integral term for having perfectly met target RPM without aggressive PD tuning, correct me if I'm wrong :)

Unfortunately it was not tested on real vehicle as for some reason all the builds with PROJECT_BOARD=proteus option are ending up creating image for default F407... Will try it out as soon as I'll figure out how to build it properly

@rusefillc
Copy link
Contributor

this #5635 PR shows 10 commits and this bothers my OCD just a bit. While rebase has risks it gives cleanest commit history

unit tests are not happy?

@pchmura4
Copy link
Contributor Author

yes, you are right, unfortunately I have no access to test result what went wrong there, nor I can't reproduce it myself... I think we can just cancel that...

@rusefillc
Copy link
Contributor

Not enough data for unittest_PressureRatio/4.logicdata
[       OK ] InjectorModel/FlowRateFixture.PressureRatio/4 (0 ms)
[----------] 5 tests from InjectorModel/FlowRateFixture (2 ms total)

[----------] Global test environment tear-down
[==========] 626 tests from 127 test suites ran. (1044 ms total)
[  PASSED  ] 625 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] idle_v2.timingPid

 1 FAILED TEST
All triggers exported to triggers.txt
Error: Process completed with exit code 255.

@rusefillc rusefillc merged commit 0a7cd2b into rusefi:master Oct 24, 2023
66 checks passed
@rusefillc
Copy link
Contributor

Unfortunately it was not tested on real vehicle as for some reason all the builds with PROJECT_BOARD=proteus option are ending up creating image for default F407...

@pchmura4 #5225

@pchmura4 pchmura4 deleted the cl_ignition branch October 25, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants