New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed Loop Idle Ignition Timing small improvements #5635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this #5635 PR shows 10 commits and this bothers my OCD just a bit. While rebase has risks it gives cleanest commit history unit tests are not happy? |
yes, you are right, unfortunately I have no access to test result what went wrong there, nor I can't reproduce it myself... I think we can just cancel that... |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For aggressively tuned CL Idle Timing in some cases it could have a harsh entry after Cranking Taper to Idle.
I would like to introduce a simple idea that can make this more subtle I think.
Also I think it would be nice to enable Integral term for having perfectly met target RPM without aggressive PD tuning, correct me if I'm wrong :)
Unfortunately it was not tested on real vehicle as for some reason all the builds with PROJECT_BOARD=proteus option are ending up creating image for default F407... Will try it out as soon as I'll figure out how to build it properly