This repository has been archived by the owner on Apr 15, 2020. It is now read-only.
Update libigl to 2.0.0-e33f534-p1 #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed this guide
step by step carefully. Yes
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
For reference, long builds where some toolchains failed:
This update will break few old toolchains.
They are excluded in this pull request: libigl: Exclude broken toolchains ingenue/hunter#374
The old
libiglpackage simply copied the headers+implementation files and did not build the actual code. By turning on theLIBIGL_USE_STATIC_LIBRARYflag, normal library build behavior is enforced. @ruslo