Update rusoto_core to Rust 2018. #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
srijs
reviewed
Apr 23, 2019
| @@ -153,8 +153,8 @@ impl Future for BufferedHttpResponseFuture { | |||
| type Error = HttpDispatchError; | |||
|
|
|||
| fn poll(&mut self) -> Poll<Self::Item, Self::Error> { | |||
| self.future.poll().map_err(|err| err.into()).map(|async| { | |||
| async.map(|body| BufferedHttpResponse { | |||
| self.future.poll().map_err(|err| err.into()).map(|r#async| { | |||
There was a problem hiding this comment.
Nit: Instead of using a raw identifier here, we should probably restructure this to use the try_ready! macro from futures; e.g:
let body = try_ready!(self.future.poll());
Ok(Async::Ready(BufferedHttpResponse {
...
}))There was a problem hiding this comment.
Thanks for the pointer! Any changes aside from edition = "2018" in Cargo.toml was the work of cargo fix but it's good to know we can make it better.
|
I'm tied up the next few days, shall we merge this in as-is and refactor later? |
|
Totally!
…On Fri, Apr 26, 2019, at 3:10 PM, Matthew Mayer wrote:
I'm tied up the next few days, shall we merge this in as-is and refactor later?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#1360 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUNTLONMNRTQLEZHZORBQDPSKFDLANCNFSM4HHUTZ2Q>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:
Update rusoto_core to use Rust 2018 edition.