Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled SQLcipher to v4.5.1 (equivalent to SQLite 3.37.2) #1131

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Mar 5, 2022

There was another release of SQLcipher the other day: https://www.zetetic.net/blog/2022/03/03/sqlcipher-4.5.1-release

Kinda a bummer that it's not fully up to date (not quite up to date with SQLite version 3.38.0, a single version behind), but TBH I'm happy it got updated at all. (I had heard that the unstable codec api that SQLcipher is based on was removed from SQLite's internals, and became very worried, but even at the best of times, SQLcipher updates can be... sporadic).

Anyway I'll probably cut a libsqlite3-sys patch release shortly after landing this, since nobody should be broken by this update, and some people may be worried about the DB corruption it fixes (or may want some of the shiny stuff from the SQLite bump, like STRICT tables).

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #1131 (ab3f30e) into master (8141b5e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1131   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files          47       47           
  Lines        5809     5809           
=======================================
  Hits         4550     4550           
  Misses       1259     1259           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8141b5e...ab3f30e. Read the comment docs.

@thomcc thomcc merged commit db8f70f into rusqlite:master Mar 5, 2022
@thomcc thomcc deleted the bump-sqlcipher branch March 5, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant