Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SqlInputError with offset #1137

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Mar 13, 2022

Should fix #1130

  • sqlite3_declare_vtab ?
  • offset specified only when code is SQLITE_ERROR ?
  • Batch => offset relative to SqlInputError.sql (not Batch.sql)
  • execute_batch => offset relative to SqlInputError.sql (not execute_batch sql parameter)
  • modern_sqlite feature, I know...

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1137 (8f40fd1) into master (f54e550) will increase coverage by 0.04%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
+ Coverage   78.82%   78.86%   +0.04%     
==========================================
  Files          48       48              
  Lines        6034     6051      +17     
==========================================
+ Hits         4756     4772      +16     
- Misses       1278     1279       +1     
Impacted Files Coverage Δ
src/error.rs 26.44% <75.00%> (+12.16%) ⬆️
src/statement.rs 91.93% <90.00%> (-0.05%) ⬇️
src/inner_connection.rs 66.29% <100.00%> (-0.57%) ⬇️
src/types/mod.rs 95.20% <0.00%> (-0.25%) ⬇️
src/lib.rs 89.62% <0.00%> (-0.02%) ⬇️
src/busy.rs 62.06% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54e550...8f40fd1. Read the comment docs.

@gwenn gwenn marked this pull request as ready for review April 21, 2022 13:27
Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Anything else you want to do with it still?

@gwenn gwenn merged commit 7b0fb7d into rusqlite:master Apr 24, 2022
@gwenn gwenn deleted the error_offset branch April 24, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error offsets
2 participants