Add some missing wrappers #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlite3_bind_*64 vs sqlite3_bind_* sqlite3_changes64 vs sqlite3_changes sqlite3_db_readonly sqlite3_error_offset sqlite3_index_info.colUsed sqlite3_index_info.idxFlags sqlite3_prepare_v3 vs sqlite3_prepare_v2 sqlite3_normalized_sql sqlite3_stmt_isexplain sqlite3_result_*64 vs sqlite3_result_* sqlite3_result_subtype sqlite3_trace_v2 vs sqlite3_trace sqlite3_txn_state sqlite3_value_subtype sqlite3_value_nochange sqlite3_value_frombind sqlite3_vtab_collation sqlite3_vtab_config sqlite3_vtab_distinct sqlite3_vtab_in sqlite3_vtab_nochange sqlite3_vtab_rhs_value
sqlite3_value_subtype sqlite3_result_subtype sqlite3_changes64 sqlite3_vtab_config
sqlite3_index_info.idxFlags sqlite3_index_info.colUsed sqlite3_vtab_distinct sqlite3_vtab_in
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
- Coverage 78.43% 78.21% -0.22%
==========================================
Files 47 47
Lines 5842 5927 +85
==========================================
+ Hits 4582 4636 +54
- Misses 1260 1291 +31
Continue to review full report at Codecov.
|
thomcc
approved these changes
Mar 15, 2022
| #[repr(i32)] | ||
| #[non_exhaustive] | ||
| #[cfg(feature = "modern_sqlite")] // 3.7.7 | ||
| pub enum VTabConfig { |
There was a problem hiding this comment.
Any reason not to derive at least #[derive(Debug, Clone, Copy, PartialEq)]?
sqlite3_db_readonly sqlite3_txn_state sqlite3_stmt_isexplain sqlite3_index_info.idxStr sqlite3_vtab_collation
thomcc
reviewed
Mar 16, 2022
src/lib.rs
Outdated
| /// Determine if a database is read-only | ||
| #[cfg(feature = "modern_sqlite")] // 3.7.11 | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "modern_sqlite")))] | ||
| pub fn db_readonly(&self, db_name: DatabaseName<'_>) -> Result<bool> { |
There was a problem hiding this comment.
nit: maybe is_readonly() is a better name for the public API?
src/transaction.rs
Outdated
| /// Determine the transaction state of a database | ||
| #[cfg(feature = "modern_sqlite")] // 3.37.0 | ||
| #[cfg_attr(docsrs, doc(cfg(feature = "modern_sqlite")))] | ||
| pub fn txn_state(&self, db_name: Option<crate::DatabaseName<'_>>) -> Result<TransactionState> { |
There was a problem hiding this comment.
nit: maybe transaction_state is a better name for the public API?
|
Could you please tell me how to force github workflow ? |
|
Huh, weird. Not sure why it's not running. You might be able to make it work by going https://github.com/rusqlite/rusqlite/actions/runs/1988699286 and clicking rerun? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite3_vtab_distinctsqlite3_vtab_inVTabConfigmodern_sqlitemeans >= 3.37.0Fix #598
Also see #639, #1001