Fix non-bundled tests against macOS system SQLite #1153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS we fail some tests when they're run against system SQLite. These may be bugs in the macOS system SQLite (since
PRAGMA compile_options
says thatBUG_COMPATIBLE_20160819
is enabled, which seems a little ominous), but the fixes for these are easy enough.I only bothered checking that the mode behaves as expected for bundled in
test_pragma_query_row
and not inpragma_update_and_check
, since the latter seems to be mostly about testing that compilation doesn't fail.