Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-bundled tests against macOS system SQLite #1153

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Apr 3, 2022

On macOS we fail some tests when they're run against system SQLite. These may be bugs in the macOS system SQLite (since PRAGMA compile_options says that BUG_COMPATIBLE_20160819 is enabled, which seems a little ominous), but the fixes for these are easy enough.

I only bothered checking that the mode behaves as expected for bundled in test_pragma_query_row and not in pragma_update_and_check, since the latter seems to be mostly about testing that compilation doesn't fail.

@thomcc
Copy link
Member Author

thomcc commented Apr 3, 2022

I'm just going to land this after CI is green since it's trivial and is bothering me right now.

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #1153 (e90ed8e) into master (f8b9ad8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   78.21%   78.22%           
=======================================
  Files          47       47           
  Lines        5927     5929    +2     
=======================================
+ Hits         4636     4638    +2     
  Misses       1291     1291           
Impacted Files Coverage Δ
src/lib.rs 90.10% <100.00%> (ø)
src/pragma.rs 90.99% <100.00%> (+0.04%) ⬆️
tests/deny_single_threaded_sqlite_config.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b9ad8...e90ed8e. Read the comment docs.

@thomcc thomcc merged commit 9699b4a into rusqlite:master Apr 3, 2022
@thomcc thomcc deleted the macos-sqlite branch April 3, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant