Improve the docs for opening the connection a bit #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
- Coverage 78.22% 78.18% -0.04%
==========================================
Files 47 47
Lines 5929 5932 +3
==========================================
Hits 4638 4638
- Misses 1291 1294 +3
Continue to review full report at Codecov.
|
gwenn
reviewed
Apr 4, 2022
| /// Most of these are also the default settings for the C API, although | ||
| /// technically the default locking behavior is controlled by the flags used | ||
| /// when compiling SQLite -- rather than let it vary, we choose `NO_MUTEX` | ||
| /// because it's a fairly clear best choice for users this library. |
There was a problem hiding this comment.
Crap, missed this comment before clicking land. Will fix.
gwenn
approved these changes
Apr 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some questions about use of
NO_MUTEXby default. I've expanded the docs and fixed some issues with them.I also updated the note about rust-postgres so that it matches the README.