Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connection::release_memory method #1164

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Conversation

nvzqz
Copy link
Contributor

@nvzqz nvzqz commented Apr 17, 2022

This is behind a new release_memory feature flag. It simply calls sqlite3_db_release_memory on the raw handle.

Open questions:

  • How should we expose sqlite3_release_memory?
  • Can we add #[doc(alias = "sqlite3_db_release_memory")]? It would require at least Rust 1.48. This can perhaps be its own issue/PR.
  • Should types with exclusive access to Connection expose this operation? Or expose the underlying connection reference?

This is behind a new `release_memory` feature flag. It simply calls
`sqlite3_db_release_memory` on the raw handle.
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #1164 (ecbb934) into master (7fb2d37) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
- Coverage   78.90%   78.85%   -0.06%     
==========================================
  Files          48       48              
  Lines        6020     6024       +4     
==========================================
  Hits         4750     4750              
- Misses       1270     1274       +4     
Impacted Files Coverage Δ
src/lib.rs 89.32% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb2d37...ecbb934. Read the comment docs.

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomcc thomcc merged commit 4d06d22 into rusqlite:master Apr 17, 2022
@nvzqz nvzqz deleted the release-memory branch April 17, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants