Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FromSql/ToSql for serde_json::Value #1252

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Nov 11, 2022

Fix #882 for valid JSON values

@gwenn gwenn requested a review from thomcc November 11, 2022 17:42
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 65.62% // Head: 65.64% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (6ca5432) compared to base (12a6d3c).
Patch coverage: 82.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   65.62%   65.64%   +0.02%     
==========================================
  Files          45       45              
  Lines        3785     3799      +14     
==========================================
+ Hits         2484     2494      +10     
- Misses       1301     1305       +4     
Impacted Files Coverage Δ
src/types/serde_json.rs 84.21% <82.35%> (-15.79%) ⬇️
src/types/value_ref.rs 49.01% <0.00%> (-2.95%) ⬇️
src/error.rs 23.28% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gwenn gwenn merged commit aad182a into rusqlite:master Dec 11, 2022
@gwenn gwenn deleted the serde_json branch December 11, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Number (Integer/Float) and Null in serde_json
1 participant