Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer panic if we fail to close the connection when dropping it. #1293

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

mhammond
Copy link
Contributor

I couldn't find any docstrings that need to be changed nor anywhere I should add to a changelog, but let me know if I missed something. The function already has #[allow(unused_must_use)] so this really is trivial.

Fixes #1292

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 81.48% // Head: 81.49% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9c2cc12) compared to base (9880cde).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
+ Coverage   81.48%   81.49%   +0.01%     
==========================================
  Files          49       49              
  Lines        9872     9867       -5     
==========================================
- Hits         8044     8041       -3     
+ Misses       1828     1826       -2     
Impacted Files Coverage Δ
src/inner_connection.rs 82.31% <100.00%> (+0.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gwenn gwenn merged commit 929be82 into rusqlite:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to avoid panic on drop behavior?
2 participants