pragma_update fails with ExecuteReturnedResults #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally, while executing a batch, we should fail if it contains a SELECT statement. But currently there is no way to make the distinction between a SELECT and a PRAGMA which both updates and returns a row. So we fail only when `extra_check` feature is activated.
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 76.36% 76.40% +0.03%
==========================================
Files 46 46
Lines 5294 5298 +4
==========================================
+ Hits 4043 4048 +5
+ Misses 1251 1250 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, while executing a batch, we should fail if it contains a SELECT
statement. But currently there is no way to make the distinction between
a SELECT and a PRAGMA which both updates and returns a row.
So we fail only when
extra_checkfeature is activated.