Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fenced code in lists #521

Merged
merged 3 commits into from Jan 24, 2019
Merged

Fix fenced code in lists #521

merged 3 commits into from Jan 24, 2019

Conversation

aignas
Copy link
Contributor

@aignas aignas commented Jan 18, 2019

This attempts to fix #495 and #485.

Note the test cases which were added at the bottom of the list. The first added test case was passing even before the changes, but the second was not.

Comments are welcome if the change in the existing behaviour is welcome.

block.go Outdated Show resolved Hide resolved
@aignas aignas changed the title RFC Attempt to fix fenced code in lists issue Fix fenced code in lists Jan 21, 2019
@rtfb
Copy link
Collaborator

rtfb commented Jan 24, 2019

In it goes. Thanks a lot, @aignas!

@rtfb rtfb merged commit a477dd1 into russross:master Jan 24, 2019
@rtfb rtfb mentioned this pull request Jan 24, 2019
4 tasks
@aignas
Copy link
Contributor Author

aignas commented Jan 24, 2019

@rtfb, thanks for taking time to review it!

willdollman pushed a commit to willdollman/blackfriday that referenced this pull request Feb 27, 2021
This attempts to fix russross#495 and russross#485.

Note the test cases which were added at the bottom of the list. The first added test case was passing even before the changes, but the second was not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block parsing for fenced code blocks with syntax highlighting in lists regression.
2 participants