Remove sanitization #117
Remove sanitization #117
Conversation
As per discussion in issue russross#90.
|
I'll review this thoroughly this evening, but huge 👍 to the overall direction! Thanks! /cc @buro9 |
|
|
||
| // ... | ||
| unsafe := blackfriday.MarkdownCommon(input) | ||
| html := bluemonday.UGCPolicy().Sanitize(string(unsafe)) |
There was a problem hiding this comment.
It might be better to rewrite this line as:
html := bluemonday.UGCPolicy().SanitizeBytes(unsafe)There was a problem hiding this comment.
Certainly, fixed that. Thanks!
|
Reviewed with more attention, and aside from comment above, this LGTM. |
|
Also reviewed it, cannot see anything lacking. Go for it. |
|
Thanks for eyeballing. |
|
It appears that this was the last place within blackfriday that was still referencing the now-dead See moby/moby#19787 for a little context. |
|
Wow, I'm special -- this PR was included in both 1.3 and 1.4; sorry for the noise! Hopefully I can track down the correct PR without too much trouble... |
|
That Docker spot is still using v1.2 -- doh, no wonder it fails. |
Following discussion in #90, this seems to be the minimal first cut at what needs to be done to transfer sanitization duties to bluemonday: removed what we had in blackfriday and added a reference to the docs.