Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Math support (MathJaX) to blackfriday.v2 #412

Open
wants to merge 2 commits into
base: v2
from

Conversation

@Vonng
Copy link

commented Nov 29, 2017

Add Math support (MathJaX) to blackfriday.v2

  • LaTeX math equation quoted by $, $$ now can be rendered properly. Compatible with many markdown editor.
  • Markdown subscript hyphen _ won't break subscript in LaTeX anymore.
  • Enable MathJaX extension with additional Extension Flag blackfriday.MathJaxSupport
墨航 and others added 2 commits Nov 4, 2017
@kaushalmodi

This comment has been minimized.

Copy link

commented Nov 29, 2017

Thanks!

Would this also take care of this issue: #411?

smartParens should be auto disabled inside equations so that (r), (c), etc. do not get inferred to registered trademark, copyright, etc. symbols.

@Vonng

This comment has been minimized.

Copy link
Author

commented Nov 30, 2017

@kaushalmodi

of course. Since smartypants render only enabled when processing Text nodes. It will have no effect on inlineMath or blockMath nodes.

The following example rendered properly with this PR under default configuration (+MathJaX)

$$
(r)(x)
$$
@kaushalmodi

This comment has been minimized.

Copy link

commented Aug 30, 2018

@rtfb Can you please look at this PR?

@martignoni

This comment has been minimized.

Copy link

commented Aug 30, 2018

This would be a big improvement as you have to disable completely Blackfriday to prevent wrong interpretations in math environments.

@rtfb

This comment has been minimized.

Copy link
Collaborator

commented Aug 30, 2018

I would like to not merge any changes that significantly change the way a source document is interpreted until we have CommonMark support (meaning that we can exercise their very exhaustive set of test cases, in addition to ours).

There is another very similar PR: #288. There's some extensive discussion on it about ideas how a math extension could be implemented without altering the semantics of a source Markdown document. The gist is that MathJaX support could be added completely outside of Blackfriday core, as a drop-in renderer that does two custom things:

  1. Add support for mathjax fenced code block language specifier, and pipe the code block through whatever processing is needed (akin to bfchroma extension for code syntax-coloring).
  2. In a similar fashion, override the behavior of the inline code span, and if it happens to be wrapped with $ signs, do the same as above.

Since the above seems to be a viable idea, I'm doubly reluctant to merge this functionality into Blackfriday core without seeing it tried out (or at least discussed in more detail if others don't see it as viable as I do).

@Eisfunke

This comment has been minimized.

Copy link

commented Sep 3, 2018

FYI: the simple $formula$/$$formula$$ syntax is used by Pandoc, as described in the manual: http://pandoc.org/MANUAL.html#math

It might be a good idea to stick to that somewhat established syntax.

@Eisfunke Eisfunke referenced this pull request Sep 3, 2018
2 of 7 tasks complete
@entron

This comment has been minimized.

Copy link

commented Oct 26, 2018

Really hope this change can be merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.