Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default status bar action to openLogs #15391

Merged
merged 1 commit into from Aug 4, 2023

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Aug 4, 2023

Previously, clicking 'rust-analyzer' would stop the server entirely. This was easy to do accidentally, and then the user has to wait for the server to start up again.

Previously, clicking 'rust-analyzer' would stop the server
entirely. This was easy to do accidentally, and then the user has to
wait for the server to start up again.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2023
@Veykril
Copy link
Member

Veykril commented Aug 4, 2023

Sounds reasonable 👍
@bors r+

@bors
Copy link
Collaborator

bors commented Aug 4, 2023

📌 Commit 1e76b11 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 4, 2023

⌛ Testing commit 1e76b11 with merge 86b6b6f...

@bors
Copy link
Collaborator

bors commented Aug 4, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 86b6b6f to master...

@bors bors merged commit 86b6b6f into rust-lang:master Aug 4, 2023
10 checks passed
@Wilfred Wilfred deleted the default_click_action branch August 4, 2023 20:35
@Zalathar
Copy link

Is there any way to configure this off?

It's broken my workflow for working on https://github.com/rust-lang/rust, where being able to easily turn r-a on and off is pretty crucial when doing any non-trivial Git operations.

@Veykril
Copy link
Member

Veykril commented Aug 11, 2023

I noticed a similar issue with my workflow afterwards 😄 I do think log being the default makes more sense but I'd like to have this configurable as well.

@lnicola
Copy link
Member

lnicola commented Aug 11, 2023

You can still hover and choose Stop server, though.

@Veykril
Copy link
Member

Veykril commented Aug 11, 2023

That's hovering, waiting and then clicking which is a lot more annoying than a mere click. I also use it with a double click to quickly restart the server when I'm testing things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants