Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of libc #56

Merged
merged 2 commits into from
Feb 16, 2020
Merged

Removal of libc #56

merged 2 commits into from
Feb 16, 2020

Conversation

dodomorandi
Copy link
Contributor

@dodomorandi dodomorandi commented Feb 16, 2020

Just replaced the libc types with the ones in std.

There is a high chance the crate won't link, because the external calls to malloc, calloc, free and fprintf are still present in the code. However, if speexdfp is used at link time, it should provide a transitive link to libc. libc dependency has been left in Cargo.toml

Should partially solve the first point of #55

@lu-zero
Copy link
Member

lu-zero commented Feb 16, 2020

Would be better to keep the libc crate until the allocations are removed.

Copy link
Member

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lu-zero lu-zero merged commit 08f1319 into rust-av:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants