Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on minimal-lexical #1709

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

nabilwadih
Copy link
Contributor

This dependency is not actually used anywhere in the project, however it was being pulled in as a dep in the Cargo.toml. This change is simply to remove it from the Cargo.toml

This is not actually used anywhere
@marshallpierce
Copy link

Beyond just trimming unused dependencies being a nice thing for simplicity, another motivation here is to avoid having to do security review on minimal-lexical and its liberal use of unsafe just to be able to use nom in an environment that does reviews on all third party code.

@Geal Geal merged commit 47de98b into rust-bakery:main Apr 21, 2024
@Geal
Copy link
Collaborator

Geal commented Apr 21, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants