Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clippy warnings #16

Merged
merged 3 commits into from
Jan 25, 2021
Merged

fix clippy warnings #16

merged 3 commits into from
Jan 25, 2021

Conversation

TianyiShi2001
Copy link
Member

Fixed clippy warnings

tedil
tedil approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jan 24, 2021 •
edited

Pull Request Test Coverage Report for Build 506915056

  • 10 of 13 (76.92%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 70.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/annot/contig.rs 0 1 0.0%
src/variant.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 471974486: 0.03%
Covered Lines: 762
Relevant Lines: 1076
💛 - Coveralls

@dcroote
Copy link
Contributor

dcroote commented Jan 24, 2021

@tedil - conflicts with master are resolved and now all clippy warnings are addressed: ready for merge!

@dcroote dcroote requested a review from tedil January 24, 2021 06:41
@tedil
Copy link
Member

tedil commented Jan 25, 2021

Thank you very much @dcroote !

@tedil tedil merged commit 40933e5 into master Jan 25, 2021
@dcroote dcroote deleted the fix-clippy branch January 25, 2021 15:20
@dcroote dcroote mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedil tedil Awaiting requested review from tedil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TianyiShi2001 @coveralls @dcroote @tedil