Revert "Fix clippy: match expr looks like matches! macro" #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 91fc873. The matches! macro was only stabilized in 1.42. Reverting in order to avoid breaking older code.
Pull Request Test Coverage Report for Build 514288415
💛 - Coveralls |
tedil
requested changes
Jan 26, 2021
The matches! macro that clippy suggested was only stabilized in 1.42 (2020-03-12). Allowing this clippy lint prevents projects using older versions of rust from breaking going forward. See also: GH-27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 91fc873, which was a part of #16.
It turns out that the
matches!macro thatclippysuggested was only stabilized in 1.42 (2020-03-12). It is probably safer to revert in order to avoid breaking older code, which happened here: rust-bio/rust-bio#410