Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump strum_macros from 0.24.3 to 0.25.1 #56

Merged
merged 1 commit into from Jul 12, 2023
Merged

build(deps): bump strum_macros from 0.24.3 to 0.25.1 #56

merged 1 commit into from Jul 12, 2023

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Jul 10, 2023 •
edited

Bump strum_macros from 0.24.3 to 0.25.1

See the related PR

dcroote
dcroote requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI to test this, the Cargo.lock file also needs to be refreshed.

Right now, 0.24.3 is still being downloaded: https://github.com/rust-bio/rust-bio-types/actions/runs/5514102016/jobs/10052972692?pr=56#step:5:22

@sjackman
Copy link
Contributor Author

For the CI to test this, the Cargo.lock file also needs to be refreshed.

Fixed!

@coveralls
Copy link

coveralls commented Jul 11, 2023 •
edited

Pull Request Test Coverage Report for Build 5522440989

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.477%
Totals Coverage Status
Change from base Build 5521697793: 0.0%
Covered Lines: 471
Relevant Lines: 742
💛 - Coveralls

dcroote
dcroote approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Dependabot should handle package bumps going forward.

@dcroote dcroote merged commit 0487bf4 into rust-bio:master Jul 12, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
Merged
@sjackman sjackman deleted the sj/bump-strum_macros branch July 12, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjackman @coveralls @dcroote