Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include doctests in test coverage calculations #397

Merged
merged 6 commits into from
Jun 20, 2023
Merged

fix: include doctests in test coverage calculations #397

merged 6 commits into from
Jun 20, 2023

Conversation

dlaehnemann
Copy link
Member

No description provided.

@dlaehnemann
update tarpaulin used in CI to latest available version
b74688b
@dlaehnemann
fix: try including --doc --examples in tarpaulin arguments, to incl…
eee736a 
…ude coverage by doctests and code examples
@dlaehnemann
revert back to 0.22.0 until tarpaulin action is fixed: actions-rs/tar…
aa10478 
…paulin#23

It seems like the download is broken in the `actions-rs/tarpaulin` GitHub Action for all tarpaulin versions above `0.22.0`. See this pending fix for details:
actions-rs/tarpaulin#23
@dlaehnemann
try with the nightly toolchain for code coverage of doctests
f71877d
@dlaehnemann dlaehnemann mentioned this pull request Jun 20, 2023
Merged
@coveralls
Copy link

coveralls commented Jun 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5324801724

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 112 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 79.613%
Files with Coverage Reduction New Missed Lines %
src/bcf/record.rs 1 78.03%
src/bam/record.rs 111 76.2%
Totals Coverage Status
Change from base Build 5175733457: 0.3%
Covered Lines: 2429
Relevant Lines: 3051
💛 - Coveralls

@dlaehnemann
Copy link
Member Author

I'm not sure why coverage seems to decrease in some places, but it does seem to increase (marginally) overall. And looking at the tarpaulin run in the CI, it is definitely running both the regular mod tests and the doctests. So I think this should improve on the previous coverage reporting.

@dlaehnemann dlaehnemann changed the title fix: include doctests (and code examples) in test coverage calculations fix: include doctests in test coverage calculations Jun 20, 2023
@johanneskoester johanneskoester merged commit 8ed0837 into master Jun 20, 2023
14 checks passed
@johanneskoester johanneskoester deleted the include-doctests-in-tarpaulin-coveralls-test-coverage branch June 20, 2023 18:04
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlaehnemann @coveralls @johanneskoester