Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for setting unmapped BAM record #136

Merged
merged 2 commits into from
May 29, 2019

Conversation

FelixMoelder
Copy link
Member

This PR makes the cigar parameter of a BAM record optional when setting variable length data.
Doing so allows to create unmapped records.

@coveralls
Copy link

coveralls commented May 28, 2019

Pull Request Test Coverage Report for Build 630

  • 13 of 15 (86.67%) changed or added relevant lines in 3 files are covered.
  • 23 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 60.067%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bam/record.rs 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
src/bcf/mod.rs 1 86.06%
src/bcf/header.rs 22 73.66%
Totals Coverage Status
Change from base Build 621: 0.1%
Covered Lines: 21406
Relevant Lines: 35637

💛 - Coveralls

Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@johanneskoester johanneskoester merged commit c32b9c4 into master May 29, 2019
@johanneskoester johanneskoester deleted the option_unmapped_bam branch May 29, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants