skip auto download when BITCOIND_SKIP_DOWNLOAD is set
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can be handy in nix environment where build script cannot hit the internet but dev-dependencies specify the auto download feature.
LeoComandini
reviewed
Apr 2, 2024
build.rs
Outdated
| @@ -71,6 +71,9 @@ mod download { | |||
| } | |||
|
|
|||
| pub(crate) fn start() -> anyhow::Result<()> { | |||
| if std::env::var_os("SKIP_DOWNLOAD").is_some() { | |||
There was a problem hiding this comment.
It's ok if we don't care about the SKIP_DOWNLOAD value? ie if SKIP_DOWNLOAD is set to "false" or 0 and we skip the download
There was a problem hiding this comment.
That's what I intended, caller can unset the var if it doesn't need it.
I can change it as preferred of course
|
Should we document the flag in the |
|
utACK 138a55f with comments, code review |
|
Maybe prefix the env var name with |
RCasatta
changed the title
BITCOIND_SKIP_DOWNLOAD is set
|
utACK 0a35cb2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can be handy in nix environment where build script cannot hit the internet but dev-dependencies specify the auto download feature.