Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cargo public-api and other tools #2848

Closed
Kixunil opened this issue Jun 9, 2024 · 2 comments
Closed

Pin cargo public-api and other tools #2848

Kixunil opened this issue Jun 9, 2024 · 2 comments
Labels

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Jun 9, 2024

We pin nightly so that our tests don't break if there's a bug in nightly but it ironically broke our CI becuase we didn't pin cargo public-api which requires nightly.

All tools should be pinned and the pins should be updated on schedule.

@Kixunil Kixunil added the ci label Jun 9, 2024
@apoelstra
Copy link
Member

Definitely +1. I would appreciate it if we could pin cargo-public-api in a way that my local CI can also pull it.

I think this might be the only offender right now. Though if we start doing cargo-mutants we will need to pin that too.

@tcharding
Copy link
Member

This was fixed in #2893 but I have a suspicion there is something funny going on still, see #2895 and #2900 for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants