CI: Pin cargo-public-api version #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
06-21-pin-cargo-public-api
branch
from
541a5b1
to
e2365f4
Compare
So that updates don't break our CI setup used a specific version of `cargo-public-api`, this means we will have to update it manually periodically though. For now, since the latest release just broke us, use the release from a month ago.
tcharding
force-pushed
the
06-21-pin-cargo-public-api
branch
from
e2365f4
to
7e3b2eb
Compare
Kixunil
approved these changes
Jun 21, 2024
| @@ -317,6 +317,6 @@ jobs: | |||
| with: | |||
| toolchain: ${{ needs.Prepare.outputs.nightly_version }} | |||
| - name: "Install cargo-public-api" | |||
| run: cargo install --locked cargo-public-api | |||
| run: cargo install cargo-public-api@0.35.0 --locked | |||
There was a problem hiding this comment.
Why change the order? I'm surprised it even works. Usually switches go before positional arguments.
There was a problem hiding this comment.
I would guess that as long as everything is after install it'll work in any order.
There was a problem hiding this comment.
Oh woops I just cut and pasted it from the docs at some stage while I was playing with it, I should not have included that change.
apoelstra
approved these changes
Jun 21, 2024
This was referenced Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that updates don't break our CI setup used a specific version of
cargo-public-api, this means we will have to update it manually periodically though.For now, since the latest release just broke us, use the release from a month ago.