Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that serde impl of LeafVersion uses u8 in consensus encoding #764

Closed
Kixunil opened this issue Jan 9, 2022 · 0 comments · Fixed by #778
Closed

Document that serde impl of LeafVersion uses u8 in consensus encoding #764

Kixunil opened this issue Jan 9, 2022 · 0 comments · Fixed by #778
Labels
good first issue P-low Low priority trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
Taproot
Milestone
0.28.0

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Jan 9, 2022

Originally posted by @Kixunil in #718 (comment)
@Kixunil Kixunil added documentation good first issue P-low Low priority trivial Obvious, easy and quick to review (few lines or doc-only...) labels Jan 9, 2022
@Kixunil Kixunil mentioned this issue Jan 9, 2022
Merged
@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Jan 10, 2022
@dr-orlovsky dr-orlovsky added this to In process in Taproot Jan 13, 2022
@dr-orlovsky dr-orlovsky linked a pull request Jan 13, 2022 that will close this issue
Fixups for taproot improvements #778
Merged
@dr-orlovsky dr-orlovsky mentioned this issue Jan 13, 2022
Merged
sanket1729 added a commit that referenced this issue Jan 13, 2022
@sanket1729
Merge #778: Fixups for taproot improvements
b2de2bc 
62a27a5 Document that serde impl of LeafVersion uses u8 in consensus encoding (Dr Maxim Orlovsky)
73e6ce4 Re-export Witness at crate level. Closes #770 (Dr Maxim Orlovsky)
6364ebd Code style fixups to taproot key functions (Dr Maxim Orlovsky)
7514f2c Tweaked  -> untweaked keys conversions (Dr Maxim Orlovsky)

Pull request description:

  This addresses @Kixunil review comments in #696 post-merge

  Update: also closes nits from issues #764 and #770

ACKs for top commit:
  Kixunil:
    ACK 62a27a5
  sanket1729:
    utACK 62a27a5

Tree-SHA512: 2f10393abab41d1c82f4733d83bf85bd82e268a2891c156eb89744c0fc444fdfec4d60deec2dda6fde2e5881989625c18b9c5ca21d360018edba69b6d2a85eae
Taproot automation moved this from In process to Done Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue P-low Low priority trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
Taproot
Done
Milestone
0.28.0
Development

Successfully merging a pull request may close this issue.

Fixups for taproot improvements
2 participants
@dr-orlovsky @Kixunil