Remove network::Error #1032
Merged
Remove network::Error #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
previously approved these changes
Jun 1, 2022
|
This approach looks good to me, but I should mention two alternatives:
|
The `network::Error` is not used, remove it.
tcharding
force-pushed
the
06-02-remove-network-error
branch
from
94680a5
to
99aab44
Compare
|
Lolz, terrible work by me. The error is not even used, we can just remove it. (Found by exploring your suggestions @apoelstra). |
I am also to blame here :) |
apoelstra
approved these changes
Jun 2, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
99aab44 Remove network::Error (Tobin C. Harding) Pull request description: The `network::Error` is not used, remove it. (This description has been changed, the thumbs up emojis were put on the previous PR description.) ACKs for top commit: sanket1729: reACK 99aab44 apoelstra: ACK 99aab44 Tree-SHA512: 2342531160966860b7b65f8c5df10e169876ec446e6fd30093d5d81d0b0304cad04e2c2057eb3ca6b23a2fc56453c91ad4ddf426d3796fb301acb7f7d03a66b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
network::Erroris not used, remove it.(This description has been changed, the thumbs up emojis were put on the previous PR description.)