Remove extern crates #1041
Merged
Remove extern crates #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
added a commit
to rust-bitcoin/bitcoin_hashes
that referenced
this pull request
Jun 7, 2022
aba33d1 Fix macro usage in macros (Tobin C. Harding) Pull request description: Currently we have macros that call other macros without a fully qualified path, this breaks some usage of the macros downstream because macro calls that should be opaque require importing. Fix macro usage in macros by using `$crate::` fully qualified path. Done in preparation for removing `extern crate` and `macro_use` in `rust-bitcoin` (since we have edition 2018). See rust-bitcoin/rust-bitcoin#1041 for demonstration of using the changes proposed here. ACKs for top commit: apoelstra: ACK aba33d1 Tree-SHA512: 4c2f103baf7cfcb61e7d3bd333dca69258dd2e9c597ae93aea9b4c3987a5bfa799a09587f6ffbe106da8206de20a74264c7edfbda05ed927f2de700f4458b314
|
Seeing all those |
|
Soon as v0.29.0 is out crate smashing is the next big task, I copied your comment over there so it doesn't get forgotten. ref: #787 |
tcharding
force-pushed
the
06-06-extern-crates
branch
from
dc08169
to
8ae635b
Compare
tcharding
changed the title
tcharding
force-pushed
the
06-06-extern-crates
branch
3 times, most recently
from
a67a59c
to
c23c3ff
Compare
apoelstra
previously approved these changes
Jun 28, 2022
tcharding
force-pushed
the
06-06-extern-crates
branch
from
c23c3ff
to
9b34aed
Compare
tcharding
force-pushed
the
06-06-extern-crates
branch
from
9b34aed
to
7b50e82
Compare
apoelstra
previously approved these changes
Jul 19, 2022
sanket1729
previously approved these changes
Jul 19, 2022
Now we have edition 2018 we do not need to use `macro_use` or `extern crate`; `pub use` works with macros. Remove the extern crate statement and replace it with a pub use statement. Requires fixing up various imports statements and also requires importing `sha256t_hash_newtype` macro directly instead of using a qualified path to it.
Recently we removed the "unstable" feature, I missed the duplicate `extern crate test` when doing so :( Since we no longer have the "unstable" feature this line of code is never compiled in. Remove the unused ``extern crate test`, we have the correct line further up the file `#[cfg(bench)] extern crate test;`.
Now we have edition 2018 we do not need to use `macro_use` or `extern crate`; `pub use` works with macros. Notable exceptions are `alloc` and `test`. Also leave the serde rename because touching it opens a can of worms.
For internal macros used only in this crate we do not need to use `macro_use` and pollute the top level namespace now that we have edition 2018. We can add a `pub(crate) use` statement to each and then path imports work for the macros like normal types.
tcharding
force-pushed
the
06-06-extern-crates
branch
from
7b50e82
to
21a1cc7
Compare
3 tasks
apoelstra
approved these changes
Jul 20, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
21a1cc7 Use pub(crate) for macros instead of macro_use (Tobin C. Harding) 23ee093 Remove extern crate (Tobin C. Harding) da8b1b5 Remove unused extern crate test (Tobin C. Harding) 01a8cc6 Remove extern crate bitcoin_hashes (Tobin C. Harding) Pull request description: Do some clean up of `extern crate` statements now we have edition 2018. 4 separate but very similar patches, separated to ease review. ACKs for top commit: sanket1729: utACK 21a1cc7 apoelstra: ACK 21a1cc7 Tree-SHA512: fba33ed8fd261cc756dad8dd94f186a5b38aaf20cf31c3a83ad7633e7bb60a390681c39ebfd913e9e242fffed3b502491d067250d72ebfe666b4d03e93c8b945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do some clean up of
extern cratestatements now we have edition 2018.4 separate but very similar patches, separated to ease review.