Clear clippy warnings from --all-targets
#1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clippy emits: warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` As suggested, use `if let`.
Clippy emits: warning: this `if` statement can be collapsed As suggested, collapse the if statements into a single statement, with no loss of clarity.
Clippy emits: warning: redundant field names in struct initialization As suggested, remove redundant field names in struct initialization.
Clippy emits: warning: digits grouped inconsistently by underscores Add allow directive for grouping that aims to make explicit 100,000,000 sats/per bitcoin.
Clippy emits: warning: used `assert_eq!` with a literal bool Use `assert!` instead of `assert_eq!(foo, true)`.
Clippy emits: warning: casting integer literal to `usize` is unnecessary Remove the unnecessary cast.
Clippy emits: warning: redundant clone Remove the redundant calls to clone.
Clippy emits: warning: `assert!(false)` should probably be replaced As suggested, replace assert with a call to panic.
Clippy emits: warning: manual implementation of an assign operation Use the more conventional `+=` operator.
Clippy warns about creating a reference that is immediately de-referenced. Remove unnecessary explicit `&`, while we are at it remove unnecessary explicit types that appear on the same lines of code.
Clippy emits: warning: using `clone` on type `blockdata::transaction::OutPoint` which implements the `Copy` trait Remove calls to `clone` from types that implement `Copy`.
Clippy emits: warning: called `map(..).flatten()` on `Iterator` As suggested, use `flat_map` instead of chaining `map` with `flatten`.
Clippy emits: warning: returning the result of a `let` binding from a block Remove the local binding, return the `Address` directly.
Clippy emits: warning: length comparison to zero Remove length comparison to zero, use `!is_empty`.
Clippy warns of useless use of `vec!` macro, remove it.
Clippy emits: warning: you seem to want to iterate on a map's values As suggested, iterate using `values`.
Clippy emits: warning: calls to `push` immediately after creation Use `vec` instead of pushing to a mutable vector.
This is a unit test helper function, it is ok to have a whole bunch of arguments.
|
Thanks guys! Just got all the feature gate code to go and then hopefully we can get clippy running on CI. |
apoelstra
approved these changes
Jun 8, 2022
|
Yep, lots of commits but all small and non-controversial. |
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
…ll-targets` 271d0ba Allow many arguments in test function (Tobin C. Harding) c0c88fe Use vec instead of pushing to a mutable vector (Tobin C. Harding) 73066e7 Use values() to iterate map values (Tobin C. Harding) 38ff025 Remove useless use of vec! (Tobin C. Harding) d8e82d5 Remove length comparison to zero (Tobin C. Harding) c1f34f5 Return Address directly (Tobin C. Harding) ff8d585 Use flat_map instead of map().flatten() (Tobin C. Harding) b24a112 Remove calls to clone from types that implement Copy (Tobin C. Harding) 2b8d93e Remove unnecessary explicit reference (Tobin C. Harding) ef90e3d Use plus-equals operator (Tobin C. Harding) 922b820 Replace assert!(false) with panic! (Tobin C. Harding) a8039e1 Remove redundant clone (Tobin C. Harding) cf8de73 Remove unnecessary cast of integer literal (Tobin C. Harding) 999ac45 Do not use assert_eq with literal bool (Tobin C. Harding) 827fcd8 Allow unusual digit grouping (Tobin C. Harding) 242c640 Remove redundant field names (Tobin C. Harding) 0f8f4c5 Collapse if statements (Tobin C. Harding) 229fcb9 Use if let instead of destructuring pattern (Tobin C. Harding) Pull request description: Clear all the clippy warnings (excl. #1042) that are returned by running `cargo clippy --all-targets`. I apologize in advance for the review burden :) ACKs for top commit: elichai: ACK 271d0ba apoelstra: ACK 271d0ba Tree-SHA512: 71ad2ec3db808e795791b7513f8b2a1c13dc90317f5328602c9ecbc31c09f82471f79c9c31a71a0ded5280554d1019d2bb4899fb9e8fa6421d46a2397cd31242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear all the clippy warnings (excl. #1042) that are returned by running
cargo clippy --all-targets.I apologize in advance for the review burden :)