Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused lifetimes #1083

Merged
merged 1 commit into from Jul 1, 2022
Merged

Remove unused lifetimes #1083

merged 1 commit into from Jul 1, 2022

Conversation

tcharding
Copy link
Member

We somehow have two lifetimes that are unused and causing clippy warnings, remove them.

This fixes the red CI runs on a bunch of other open PRs. FTR I have no idea how these got past clippy onto master.

@tcharding
Remove unused lifetimes
64152ff 
We somehow have two lifetimes that are unused and causing clippy
warnings, remove them.
This was referenced Jul 1, 2022
Merged
Merged
Kixunil
Kixunil approved these changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 64152ff

@Kixunil Kixunil added trivial Obvious, easy and quick to review (few lines or doc-only...) one ack PRs that have one ACK, so one more can progress them clippy Issues and PRs related to fixing clippy warnings labels Jul 1, 2022
apoelstra
apoelstra approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 64152ff

@apoelstra apoelstra merged commit 21abc42 into rust-bitcoin:master Jul 1, 2022
@tcharding tcharding deleted the 07-01-clippy branch July 10, 2022 22:00
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
@apoelstra
Merge rust-bitcoin/rust-bitcoin#1083: Remove unused lifetimes
a24a5d8 
64152ff Remove unused lifetimes (Tobin C. Harding)

Pull request description:

  We somehow have two lifetimes that are unused and causing clippy warnings, remove them.

  This fixes the red CI runs on a bunch of other open PRs. FTR I have no idea how these got past clippy onto master.

ACKs for top commit:
  Kixunil:
    ACK 64152ff
  apoelstra:
    ACK 64152ff

Tree-SHA512: cced838b575b29d90c4325ab42ada93bae4751721d3ca2c19ec801892c38130570613e4ab8de757b73ecc83cda5c00a32867139e04a2615833d05dc21551af1a
@Kixunil Kixunil added this to the 0.29.0 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpc dpc dpc approved these changes

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
clippy Issues and PRs related to fixing clippy warnings one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tcharding @dpc @Kixunil @apoelstra