Regtest bech32 address support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We really need to move to a https://github.com/rust-bitcoin/bitcoin-constants lib so that we dont have to keep doing network-tag-enum conversion. |
|
@TheBlueMatt happy to get this integrated as is or you consider the refactoring to bitcoin-constants as blocking? |
|
Not for something as simple as this, no, but it really needs to happen.
…On July 27, 2018 12:26:02 AM UTC, Franck Royer ***@***.***> wrote:
@TheBlueMatt happy to get this integrated as is or you consider the
refactoring to bitcoin-constants as blocking?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#110 (comment)
|
6 tasks
|
@TheBlueMatt can you advise how I can get this merged? Thanks! |
apoelstra
approved these changes
Aug 11, 2018
There was a problem hiding this comment.
I'll merge for now. bitcoin-constants is a hard project to get right - every addition to a public enum requires a major version bump, which then requires all downsteam users to do a major version bump, and it's easy for people to be disrupted by changes to constants that they don't even care about.
Davidson-Souza
pushed a commit
to Davidson-Souza/rust-bitcoin
that referenced
this pull request
Jul 12, 2023
Bump version to 0.13
casey
pushed a commit
to casey/rust-bitcoin
that referenced
this pull request
Nov 28, 2023
Fix the GetNetworkInfoResult time_offset field
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
policy: Corrected an inverted documentation for `Older` and `After`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #84, add support for regtest bech32 addresses that start with "bcrt1".
Also added a test that I had added locally when updating rust-bitcoin with my rust-bech32-bitcoin/regtest library.
Please consider this PR, thanks!