New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bip152 module to crate root #1210
Move bip152 module to crate root #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c77f3f5
c77f3f5
to
884747e
Compare
Rebase to pick up recent fuzzer change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 884747e
884747e
to
458006d
Compare
Rebase only, no other changes. |
Needs rebase again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 458006d
458006d
to
549e54b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 549e54b
549e54b
to
89361eb
Compare
Rebase only, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 89361eb
89361eb
to
1ac02b8
Compare
Rebase only, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1ac02b8
1ac02b8
to
b54b1d6
Compare
Rebase only, no other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b54b1d6
89072a9
to
6b01e96
Compare
Rebase only, no other changes. |
6b01e96
to
ecda366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ecda366
We are attempting to flatten the `util` module; move the `bip152` module to the crate root out of `util`. Currently `src/util/` is ignored by the formatter so this move causes the `bip152` module to be formatted.
Run the formmater on the newly moved `bip152` module. No changes other than those introduced by `cargo +nightly fmt`.
ecda366
to
4057c26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4057c26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review ACK 4057c26
We are attempting to flatten the
util
module.Move the
bip152
module to the crate root out ofutil
.Currently
src/util/
is ignored by the formatter so this move requiresbip152
module to be formatted. Formatting is done as a separate patch so reviewers can runcargo +nightly fmt
and compare the diffs if so desired.