Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bip152 module to crate root #1210

Merged
merged 2 commits into from Oct 19, 2022

Conversation

tcharding
Copy link
Member

We are attempting to flatten the util module.

Move the bip152 module to the crate root out of util.

Currently src/util/ is ignored by the formatter so this move requires bip152 module to be formatted. Formatting is done as a separate patch so reviewers can run cargo +nightly fmt and compare the diffs if so desired.

apoelstra
apoelstra previously approved these changes Aug 24, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c77f3f5

@tcharding
Copy link
Member Author

Rebase to pick up recent fuzzer change.

apoelstra
apoelstra previously approved these changes Aug 25, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 884747e

@tcharding tcharding added this to the 0.30.0 milestone Aug 26, 2022
@tcharding tcharding added minor API Change This PR should get a minor version bump 1.0 Issues and PRs required or helping to stabilize the API aggregate release notes mention labels Aug 26, 2022
@tcharding
Copy link
Member Author

Rebase only, no other changes.

@apoelstra
Copy link
Member

Needs rebase again :)

apoelstra
apoelstra previously approved these changes Sep 6, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 458006d

apoelstra
apoelstra previously approved these changes Sep 7, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 549e54b

@tcharding
Copy link
Member Author

Rebase only, no other changes.

apoelstra
apoelstra previously approved these changes Sep 12, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 89361eb

@tcharding tcharding added this to In progress in Refactoring via automation Sep 13, 2022
Refactoring automation moved this from In progress to Review in progress Sep 14, 2022
@tcharding
Copy link
Member Author

Rebase only, no other changes.

apoelstra
apoelstra previously approved these changes Sep 14, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1ac02b8

@tcharding
Copy link
Member Author

Rebase only, no other changes.

apoelstra
apoelstra previously approved these changes Sep 20, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b54b1d6

@tcharding
Copy link
Member Author

Rebase only, no other changes.

apoelstra
apoelstra previously approved these changes Sep 28, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ecda366

We are attempting to flatten the `util` module; move the `bip152` module
to the crate root out of `util`.

Currently `src/util/` is ignored by the formatter so this move causes
the `bip152` module to be formatted.
Run the formmater on the newly moved `bip152` module. No changes other
than those introduced by `cargo +nightly fmt`.
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4057c26

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review ACK 4057c26

Refactoring automation moved this from Review in progress to Reviewer approved Oct 19, 2022
@apoelstra apoelstra merged commit 938b61b into rust-bitcoin:master Oct 19, 2022
Refactoring automation moved this from Reviewer approved to Done Oct 19, 2022
@tcharding tcharding deleted the 08-24-rustfmt-bip152 branch October 19, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API aggregate release notes mention minor API Change This PR should get a minor version bump
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants