New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bip158 module to crate root #1211
Conversation
The new match-arm formatting looks kinda bad to me but I won't die on this hill. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bcc7afc
Now you mention it, I tend to agree. So as not to open up a can of worms right now perhaps we can leave it like this and come back to it at a later time? |
If you mean, leaving this file blacklisted by |
I'll leave the new formatting, I'm pretty sure this was one of the config changes introduced during the "less vertical lines is better" debate. |
We are attempting to flatten the `util` module; move the `bip158` module to the crate root out of `util`. Currently `src/util/` is ignored by the formatter so this move causes the `bip32` module to be formatted.
Run the formmater on the newly moved `bip158` module. No changes other than those introduced by `cargo +nightly fmt`.
bcc7afc
to
01161e6
Compare
Rebase to pick up recent fuzzer change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 01161e6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 01161e6
We are attempting to flatten the
util
module.Move the
bip158
module to the crate root out ofutil
.Currently
src/util/
is ignored by the formatter so this move requiresbip158
module to be formatted. Formatting is done as a separate patch so reviewers can runcargo +nightly fmt
and compare the diffs if so desired.