Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus::Params should be non_exhaustive #1216

Merged
merged 1 commit into from Aug 29, 2022

Conversation

hrouis
Copy link
Contributor

@hrouis hrouis commented Aug 26, 2022

fixes: #1213

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 445037f

@tcharding
Copy link
Member

tcharding commented Aug 29, 2022

Thanks for the contribution @hrouis, we appreciate your efforts. Can I offer a couple of high level comments

  • If you put fixes: #1213 in the PR description github will autoclose the issue for us.

There are a bunch of other keywords one can use instead of 'fixes', here is a list https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

  • There is a nice blogpost on writing good clean commit messages, I like to share it with folks. PR/commit messages help reviewers review your work more easily and as you do more involved patches will help your work get merged more easily.

https://cbea.ms/git-commit/

Thanks again man!

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 445037f

@hrouis
Copy link
Contributor Author

hrouis commented Aug 29, 2022

Thank you for the pointers and links, will definitely apply them for the next PRs

Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 445037f

I don't mind the commit message here, this is almost as trivial as fixing a typo. :)

@apoelstra apoelstra merged commit 5548696 into rust-bitcoin:master Aug 29, 2022
@hrouis hrouis deleted the non_exhaustive_params branch August 29, 2022 21:55
@tcharding
Copy link
Member

Thank you for the pointers and links, will definitely apply them for the next PRs

Thanks man, hope I didn't come across too nit-picky :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consensus::Params should probably be non_exhaustive
4 participants