Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo fmt #1249

Merged
merged 1 commit into from Sep 9, 2022
Merged

Run cargo fmt #1249

merged 1 commit into from Sep 9, 2022

Conversation

tcharding
Copy link
Member

A few trivial formatting errors have snuck into the codebase.

Run cargo +nightly fmt

FTR we have an open PR to run formatter in CI: #1111

A few trivial formatting errors have snuck into the codebase.

Run `cargo +nightly fmt`
Copy link
Collaborator

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e425ac

@@ -117,7 +117,6 @@ macro_rules! debug_from_display {
};
}
pub(crate) use debug_from_display;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, empty line would be nicer here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I did #1255 to make it a little bit better

@Kixunil Kixunil added trivial Obvious, easy and quick to review (few lines or doc-only...) one ack PRs that have one ACK, so one more can progress them labels Sep 8, 2022
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e425ac

@apoelstra apoelstra merged commit 7056490 into rust-bitcoin:master Sep 9, 2022
@tcharding tcharding deleted the 08-09-rustfmt branch September 9, 2022 00:44
@tcharding tcharding added this to the 0.30.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release notes mention one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants