Fix serde versions #1267
Merged
Fix serde versions #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
added
bug
trivial
|
Lot of merges meanwhile, LOL |
`Cargo.toml` claimed that this crate works with very old versions of `serde` which wasn't the case. This commit changes the versions to minimal known-to-work values.
Kixunil
force-pushed
the
fix-serde-versions
branch
from
9878707
to
4d54b16
Compare
apoelstra
approved these changes
Sep 13, 2022
|
How do we know that we won't break this in the future. Should we have a CI job that pins serde versions and builds? |
tcharding
approved these changes
Sep 13, 2022
|
@tcharding we should pin all dependencies. I have recorded deps for #1230, I just need to modify CI and commit it. :) |
|
Oh yes, I remember now, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomlclaimed that this crate works with very old versions ofserdewhich wasn't the case. This commit changes the versions to minimal known-to-work values.Adding
trivialtag because the text change is trivial even though figuring it out wasn't. :)If you manually decrease any of the versions by 1 (in both
Cargo.tomlandCargo.lock) the build should fail.