Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return custom error from Network::from_str #1314

Merged
merged 1 commit into from Oct 18, 2022
Merged

Return custom error from Network::from_str #1314

merged 1 commit into from Oct 18, 2022

Conversation

nlanson
Copy link
Contributor

@nlanson nlanson commented Oct 10, 2022

Fix #1292

Had some time so got this out of the way.

apoelstra
apoelstra approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d1b7dff

tcharding
tcharding approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d1b7dff

@apoelstra apoelstra merged commit e10aa55 into rust-bitcoin:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrn a custom error type from Network::from_str
3 participants
@nlanson @apoelstra @tcharding