Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some comments to Transaction::weight #1331

Merged
merged 1 commit into from Oct 21, 2022

Conversation

apoelstra
Copy link
Member

FIxes #1159

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 17f0d29

@apoelstra
Copy link
Member Author

Since this is doc-only I'm gonna go ahead and merge it, but techincally @TheBlueMatt your ack shouldn't count because you didn't specify the commit ID.

@apoelstra apoelstra merged commit c5277a8 into rust-bitcoin:master Oct 21, 2022
@apoelstra apoelstra deleted the 2022-10--weight-doc branch October 21, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction::weight() differs fom the actual weight of a serialized tx with 0 inputs
3 participants